@HusseinSamy
Posted
Hello @jvssvj, 👋🏻
Awesome job on taking the first steps towards your dream!
I'm thrilled to see your engagement with this platform to enhance your design skills. I like your code organization. Though, I have some additions to make more clean:
1. Wrap all of your code inside function and call it when needed:
====> Instead of writing it like this
openMenuBtn.addEventListener('click', openCloseMenu)
closeMenuBtn.addEventListener('click', openCloseMenu)
====> Write it like this
function addEventListnersForMenuButtons(){
openMenuBtn.addEventListener('click', openCloseMenu)
closeMenuBtn.addEventListener('click', openCloseMenu)
}
====> Call it in the right place
addEventListnersForMenuButtons()
2. Use Bem for naming your styles.
3. Add meta tags to your project:
<meta name="title" content="My Website">
<meta name="description" content="My Website Description">
<meta name="keywords" content="Some, Keywords, Here">
Hope you find it useful!😇
Keep up the fantastic work, and happy coding! 🚀
Marked as helpful