Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

CSS グリッドを使用したレスポンシブランディングページ

P
amakura-411•60
@amakura-411
A solution to the 3-column preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Greetings

Hello there! 👋🌟

Request

Hey everyone from the Frontend Mentor community, could I ask for your help?

I'm seeking a code review. Do you have any advice?

Project Specification

Currently, I'm working on3-column-preview-card-component-main.

I welcome feedback from various perspectives.

Any suggestions or ideas are greatly appreciated! 🛠️

Points of Concern

In relation to this project, I don't have any specific points of concern,

but I'm open to any suggestions or ideas! 🤔

Appreciation

Your opinions and ideas are warmly welcomed!

Thank you in advance for your contributions! 🚀

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Dimitar Radev•930
    @Mitko90
    Posted over 1 year ago

    Hi, nice solution.

    It looks great. Pixel perfect

    Maybe you can check some suggestions I have for you:

    • You used three times the <h1> heading. This heading should only be used once. Maybe change it to <h2> as it can be reused. Of course every page should have an h1 heading so I suggest adding a visually-hidden one to the page, so it doesn't generate an accessibility report.
    • Your buttons should direct the user to a different part or page of the site. So maybe switch the <button> with the <a> tag.

    I had the exact same mistakes when I did this challenge so I redid it with the changes. You can, if you want, check both of my submissions here and here.

    Above all the solution you submitted looks great.

    Happy coding.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub