Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Your session has expired please log in again.
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

CSS and HTML

@elioflo

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Fatlind Shehu 2,230

@fatlindshehu

Posted

Hi @elioflo,

Nice work with the component, it looks almost identical, I would make some general suggestions on how to improve your code:

  • I would suggest using rem or em units, instead of pixel units, px can cause Issues when trying to make your site/component responsive.
  • Using a CSS naming convention would be a nice addition to your skills as a Frontend Developer, my suggestion is to use BEM which stands for Body Element Modifier, check this LINK if you’re interested in knowing more about BEM
  • Using a pre-processor like SASS or LESS would be also very nice, for bigger projects, pre-processors make the code reusability and maintenance very easy and also reading your code from other developers is much easier.
0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord