Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

CSS custom properties, Flexbox, CSS Grid, Mobile-first, native JS

Danny•200
@DannyLenk
A solution to the Space tourism multi-page website challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Yes, please. There is a thing that bothers me the most. Why could a hidden attribute not work in some places? For example, on the "destination" and "crew" pages' <article>s it works, whereas on the "technology" one it doesn't. The same problem was with the <div>s containing imgs on the technology page. So, I had to add some changes to the js files.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Godwin Martins•180
    @gmcodes20
    Posted over 3 years ago

    Hi @danny, nice one you got here. Maybe you can change the mobile menu hamburger to a pointer. Also, the crew image should be at the bottom on the larger screen and if you can also remove the border-bottom from the image on the large screen

    Marked as helpful
  • darryncodes•6,350
    @darryncodes
    Posted over 3 years ago

    Hi Danny,

    I had this exact same problem and Grace came to my rescue, something I now won't forget:

    Here's the info:

    • the display property overrides the hidden attribute and you have in your code: img, picture { max-width: 100%; display: block; }
    • try adding: [hidden] {display: none !important;}

    All the best

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub