Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

CSS flex Box, javascript event listener...

Deepu23456•110
@Deepu23456
A solution to the Article preview component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

by making this project i came to know that how good and efficient CSS is important for a developer which helps to get rid with repetitive code. So next time i will try to enhance my code optimization skills and work more on them. Thank You ......

What challenges did you encounter, and how did you overcome them?

Honestly its not that much challenging so i actually didn't encounter as such challenge but yes whenever i got stuck on some problem i refer to google and MDN documents which helps me a lot. Thank You.....

What specific areas of your project would you like help with?

I like CSS part very much and also enjoys it while coding. But not a lie i also like Js part but only when the problem is solving step by step whenever it get stuck for more than 30-40 minutes i lose my patience. Its all about this but working on that stuck part and get success in that is another level of happiness for me. Thank You....

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Daniel 🛸•44,810
    @danielmrz-dev
    Posted about 1 year ago

    Hello @Deepu23456!

    Your solution looks excelent!

    I have just one suggestion:

    📌 To improve semantic clarity, opt for <h1> over <h3> for your main title.

    It's more than just text size — it's about structuring your content effectively:

    • <h1> to <h6> are used to define HTML headings, with <h1> being the most significant.
    • Stick to one <h1> per page for the main title, and maintain the titles hierarchy with <h1>, <h2> <h3>, and so on.

    While these adjustments might not alter the visual appearance much, they significantly enhance semantic clarity, SEO optimization, and accessibility.

    Hope this suggestion proves helpful! Keep up the great work!

    Marked as helpful
  • Tharun Raj•1,330
    @Code-Beaker
    Posted about 1 year ago

    Hi there, you've done a great job regarding this solution.

    Here are some issues that I came across in your solution:

    • It seems like there is a white box below the pop-up and also the popup is not in the right position.
    • On mobile, the pop-up does not have proper width. It overflows the container.

    Here's how you can improve your code in this one:

    • instead of creating a share-container element, place the share inside the profile-section itself. Then give the profile-section the following properties:
    .profile-section {
    position: relative;
    }
    
    • then give the share element:
    .share {
    position: absolute;
    right: 0;
    bottom: 25px; /* change this value if you want */
    }
    

    There is no need of the share-container.

    • I see that you've tried to create the little triangle that joins it with the share icon. But it's actually blocking the content beneath it.

    These are small issues that can be solved to make the website better. I hope you look into the problem and understand how to fix it.

    Hope this helps you improve your solution!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub