@PhoenixDev22
Posted
Hello VasileCosmin, Congratulation on completing your first project. Your solution looks nice. I have some suggestions , To tackle the accessibility issues :
-
Document should have one main landmark. Wrap the body content in< main>tag read more about main landmark.
-
For any decorative images, each img tag should have empty ``alt=""
(as you did )
andaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images. And for this one<img src="./images/image-avatar.png" alt="">
thealt
shouldn't be empty.
-The eye image doesn't really need to be in the html, you could do it with css. If you want it to stay in html it needs to be aria-hidden or role presentation with empty alt.
-
You should use
em
andrem
units .Bothem
andrem
are flexible, scalable units which are translated by the browser into pixel values, depending on the font size settings in your design. -
You can replace the
<div class="attribution">
by a<footer >
tag and it would be out the< main>
. -
You shouldn't use
<div class="divider"></div>
. you can use border-top property for theclass="card-footer"
.
I really hope this feedback helps , happy and keep coding
Marked as helpful