Hi Vaslie
I just did a quick test and it seems to be working fine for me! Nice job. Here's a couple of points to consider:
- For the button, you should probably add an
aria-label
to help people with screen readers understand what the button does - If you really want to help them I would also add an
aria-live="polite"
to yourh1
as this will announce the text when it is rendered to screen readers too.
Otherwise I think this looks good. I like the way you included some default text for people to read while the first fetch is happening, and that you included a catch
in case of errors.
For the return of data I typically do something like response.ok ? response.json : new Error
. This also checks the returned data is fine, and adds another level of robustness to the app.
Hope this helps and nice work!
Cheers Dave
Marked as helpful
@VasileCosmin
Posted
@dwhenson I added aria label and aria live. Thank you so much for the advice