Skip to content
Submitted over 4 years ago

CSS Flexbox and javascript

Faraz Ahmad•100
@faraz343
A solution to the Coding bootcamp testimonials slider challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

I would like to have feedback . Thanks in advance

Code

Please log in to post a comment

Log in with GitHub

Community feedback

  • Jen•1,230
    @En-Jen

    Hey Faraz, nice job! Your solution looks pretty close to the design and the functionality of the slider works well. Here are some suggestions I have for you:

    1. For cleaner code, it's best to write your JS in a separate file instead of writing it directly in your HTML file.
    2. Try using more semantic HTML tags like <p> or <blockquote> instead of just <div>.
    3. Try to avoid using the <br> tag in your HTML and instead try positioning elements in CSS with flexbox or CSS grid.
    4. Your avatar image gets really stretched out at many different screen widths. One way to avoid that is by giving either the width or the height of an image a value and then setting the other measurement to auto.

    Happy coding! -Jen

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord