Jen• 1,230
@En-Jen
Posted
Hey Faraz, nice job! Your solution looks pretty close to the design and the functionality of the slider works well. Here are some suggestions I have for you:
- For cleaner code, it's best to write your JS in a separate file instead of writing it directly in your HTML file.
- Try using more semantic HTML tags like
<p>
or<blockquote>
instead of just<div>
. - Try to avoid using the
<br>
tag in your HTML and instead try positioning elements in CSS with flexbox or CSS grid. - Your avatar image gets really stretched out at many different screen widths. One way to avoid that is by giving either the width or the height of an image a value and then setting the other measurement to
auto
.
Happy coding! -Jen
1