Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

css flexbox and media queries

Om Dubey•50
@om205
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Why cannot other people see background image (using url) in my solution from github page link url?

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Tammy•100
    @Tammy-Ajoko
    Posted almost 3 years ago

    Congratulations on completing the challenge. Everything seems to be ok only thing is that your image was not visible. When working with live servers you use the absolute path but the relative path, this should serve you much better .pic { background: url(./images/image-product-desktop.jpg); }

  • Shiva•670
    @shivaprakash-sudo
    Posted almost 3 years ago

    Hello Dubey,

    GitHub looks for images using relative path, so we have to give relative path to the images instead of absolute paths. Instead of the path you've given, try ./images/your-image-name.png. Here . represents current folder (one dot means one step upwards into the folder structure), since the images are inside the images folder, you go into that to choose the image.

    Few notes to consider:

    • Try doing the design for mobile screens first and then change the layouts for bigger screens using media queries.
    • Once we code for the mobile, we don't have to repeat the same code for bigger screens too, we just change what is needed to be changed after a certain breakpoint.
    • Try not use fixed widths for images or image containers, try using max-width: 100%; for images, so that they behave responsively.
    • Try to use rem or em instead of pixels, to make the site easier for responsiveness.

    Happy coding

  • Lucas 👾•104,160
    @correlucas
    Posted almost 3 years ago

    👾Hello Om Dubey, congratulations for your new solution!

    People doesn't see your image, because when you're working with local /live server, you don't need to indicate the exact folder, the computer recognize automatically the image location.

    But when it goes to the repository you need to indicate before the image folder ./ dot slash if is a simple folder and ../ dot dot slash if is a subfolder, see the correct image import below

    }
    @media screen and (min-width: 670px)
    .pic {
        background: url(./images/image-product-desktop.jpg);
    }
    

    👋 I hope this helps you and happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub