Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

CSS Flexbox & Vanila JS

Aurel•290
@Aur71
A solution to the Interactive rating component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


How can I improve the Javascript code. I tried to select all the buttons with document.querySelectorAll() and loop trough them. I had trouble making a single button active while restricting the others.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Enmanuel Otero Montano•2,155
    @Enmanuel-Otero-Montano
    Posted almost 3 years ago

    Hello Aurel!

    I am going to leave you your code modified to achieve the same functionality but with a for loop and using the querySelectorAll as you had in mind. I just added the loop and removed the listener events for the buttons and also removed the buttons that were located by the "id"

    const submitBtn = document.getElementById('submitBtn');
    const cardItems = document.querySelector('.card-items');
    const cardThankYou = document.querySelector('.card-thank-you');
    const ratingButtons = document.querySelectorAll('.card-thank-you');
    submitBtn.disabled = true;
    
    submitBtn.onclick = () => {
      cardItems.style.display = 'none';
      cardThankYou.style.display = 'flex';
    };
    
    const allBtns = document.querySelectorAll('.ratingBtn');
    const span = document.getElementsByTagName('span')[0];
    
    for (let btn of allBtns) {
      btn.addEventListener('click', () => {
        span.innerHTML = btn.innerHTML;
        submitBtn.disabled = false;
      });
    }
    

    I would like you to try it and tell me if it works correctly for you.

    Cheers!

    Marked as helpful
  • szam•800
    @k-stopczynska
    Posted almost 3 years ago

    Hi!

    According to your question: select them by const buttons = document.querySelectorAll('.buttons-class'). You will get the Node-list of them. Add event listener to all of them and write a function which on the click:

    1. removes class active from all the buttons
    2. on the button that is an event target will add class active
    3. will provide data for your span dynamically, e. g const spanValue = e.target.innerContent; and then you can use it like this ${spanValue}

    You can also check my solution with different approach. Hope this helps:)

    You did very good on the layout!

    Happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub