Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

css flexbox, css

Leonel Meque•255
@leonelmeque
A solution to the Profile card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I would like feedback on my css code, I believe a few things could have been easier to do

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Arturo Simon•1,805
    @artimys
    Posted over 4 years ago

    Well done on the challenge Leonel. 👍👍 Looking over your css I can provide different ways to do something but overall your styling is simple.

    • Try adding the two background images to the body element as background-image. You'll probably want to tear your hair out but the key is to play with background-size first to show an acceptable size then position it with background-position.

    • Add both bg-pattern-card and hero image into a new div container. Set the bg pattern as a background-image and keep hero image as an image tag. Update position.

    • the width: 33% on your .card-footer-content .container is a fine solution. An alternative way is using the justify-content: space-around since your container is already using flexbox.

    .card-footer-content{
       display: flex;
       flex-direction: row; 
       align-items: center;
    
       // be sure to add left/right margin to your .container. to adjust outer spacing.
       justify-content: space-around;  
    
    }
    

    --

    Design feedback:

    • lower the font-weight for the "followers", "likes", "photos" text
    • reverse numbers 380K to 830K

    Keep it up 👍👍

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub