Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

Css flexbox, HTML

Celeste Rhoades•40
@Celeste-Rhoades
A solution to the Recipe page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I feel I did a decent job. Feedback is welcome

What challenges did you encounter, and how did you overcome them?

Moving from mobile first to desktop layout was slightly difficult.

What specific areas of your project would you like help with?

Tips on how to write better css

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Kira Tantari•180
    @KirativeWD
    Posted about 1 year ago

    Hi there!

    Great job finishing the project. You mentioned that you would like tips on writing better CSS and that you had some difficulty moving from mobile first to desktop.

    When moving from mobile to desktop, it's best to leave the CSS as simple as possible. You may be tempted to add styling that will be responsive when the screen size grows larger, but until you find a good groove, responsive styles can always be added within the media queries.

    1. I see you applied flex to the body element, but this is unnecessary. When flex is applied to an element, it condenses its width to the content, and with a width of 375px applied to the section container, extra space is on the left and right when the screen grows larger than 375px. For mobile view, the recipe should stretch across the screen until mid-tablet range. So, I would suggest removing those stylings. Doing so already puts you on a better trail.

    2. You have your media query set to happen at 1440px. The challenge style guide mentions that the desktop design was designed at 1440px, but this does not mean you must use that as a breakpoint. You might find it easier to follow the philosophy of adding a breakpoint when the design breaks or starts to look awkward. This is why I mentioned the recipe stretching across the screen until mid-tablet range. And if you look at the image around 1312px, it stops growing. This tells you that that is the image's max initial width. Your breakpoint should happen before then.

    3. A lot is happening at the breakpoint. Most of the changes will not be required if the CSS were simplified. For example, the body, main, .mobile, and .desktop selectors all have style applications that are unnecessary save for the border-radius. And in actuality, .desktop and .mobile could be replaced with a singular class e.g. .recipe-card

    4. You might wonder how you would center the recipe if flex is not used (because flex isn't needed for this project). What you would do instead is set a max-width on one of the containing elements (main or section) along with margin-inline: auto; Doing so will align the recipe horizontally. All you would need to do then is move the recipe down with margin.

    Sorry if this is a lot! I like to be as thorough as possible and I hope this helps!

    If you have any further questions, please feel free to ask. CSS is super fun. :)

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub