Hi Montse,
This looks OK on mobile portrait, you just need some margin around the card or padding on the container so it's not hitting the sides of the screen.
The layout breaks on mobile landscape atm, I think because of a flex row making the footer move to the side, so maybe have a look at that.
I do see some real issues with your html at the moment, so that's where I'd advise you focus your learning next:
- sections are really important semantic html tags. This whole card might be a section, but definitely not the parts within it, and definitely not nested as you have it now. Think of sections as something that would deserve to be listed on a contents page of a big document or book, that's where you use them.
- almost all content is in headings at the moment. Again, think about the meaning of the content here. The name could be a heading for the whole card, but what is the country a heading to? That should probably just be a paragraph tag.
- similarly, what would a heading of "803k" mean? The numbers don't make sense as headings and need to be read with the word that comes after them. That means placing both in one meaningful tag, like a paragraph or list item, and using classes on spans within that tag to style the two parts differently.
- Last thing is alt text. It needs to be readable as words and a meaningful description. So the name would be fine, but you never need to include words like 'image' or 'photo' of because that is already announced by the presence of the image tag itself.
I hope this makes sense and is helpful. Keep going! ☺
@kiutkat
Posted
Wow, first of all, thank you Grace for taking the time to evaluate my solution and thanks so much ofr the feedback, I really learned a lot from this comment. !