Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 11 months ago

CSS Flexbox, media query

Perry_Y_Z•130
@Perry2004
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • NeonCodes•60
    @NeonCodes
    Posted 11 months ago

    Hello, Good job completing the challenge! The design is pretty close to the original.

    First, the positive:

    • Your code is very concise and well-organized so we don't get lost while reading it (special mention for the #description selectors and @media in the stylesheet)
    • Didn't know font-optical-sizing existed, that's nice.
    • The card is well-centered and sized with flexbox.

    Second, potential area of improvement:

    • The h1 seems slightly too big. You can try font-size:22px( or convert them to rem using a converter like Calculatorway)

    I hope it helps. Happy Coding!

  • Kitalphar•280
    @Kitalphar
    Posted 11 months ago

    Great work!

    Due to having used vw units for the container width the container grows wider than probably intended, but it did gave me the idea of maybe using the resize CSS property, or adding an option to enlarge the image on hover. In the future in case on the design i'm working on the image is small it could help the camera pick the QR code up better. Just food for thought...

  • Mai Starberries•80
    @starberries
    Posted 11 months ago

    Hey @Perry2004, great work! I learned a few interesting things about font properties from looking through your styling, I didn't even know font-optical-sizing was an available property, so that's really cool.

    I did notice your container size has a lot of variability based on screen size. If you're interested in giving it a more controlled size range, I can suggest using max-width in place of width and utilizing rem units for measurement. Here's how I set up the container size for mine if you'd like a comparison:

    .container {
        max-width:20rem;
        min-height: 31rem;
    }
    

    If you need any info on rem and em, I myself was just recommended this page on the subject, but essentially rem units are based on the root font size, so 1rem by default would be 16px.

    Anyway, great work with the challenge, keep it up!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub