Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 5 months ago

CSS FlexBox, Responsive HTML, CSS Variables, Vercel Deployment

Nathan Molina•280
@Natentado
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Coco•60
    @cocoelizabeth
    Posted 5 months ago

    Hi Natentado! Your solution is great! Here are a few minor suggestions for improvement:

    1. Responsive Design: The layout adjusts well across different screen sizes, maintaining a central alignment and appropriate scaling of the QR code image. Consider adding media queries to adjust the padding or margins on smaller screens to utilize space more efficiently. (e.g., there would be no padding on the iPhone SE, which has a viewport width of 320px)

    2. Code Quality: The code is clean and well-structured. CSS properties are consistently ordered, which improves readability. To increase reusability, consider using CSS variables for colors and fonts.

    3. Design Fidelity: While the implementation is generally in line with the original design, there are a couple of deviations to note:

    • The original design includes a drop shadow around the qr-code-container component, which is not shown in your solution. Adding a CSS .drop-shadow or .box-shadow would enhance the visual depth and make it more similar to the original design.
    • The font rendering appears slightly different than in the design mockup, however, I don't think it affects the overall feel of the component.
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub