Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

CSS Flexbox; Semantic HTML; Media Query

Bruno Afonso•110
@BrunoAfonsoOliveira
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I had a hard time keeping the elements within the limit of their space, I ended up letting a padding pop out of the box

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Sajana Wijesinghe•460
    @StormKing969
    Posted almost 3 years ago

    Hi.

    When I looked at your css file, I saw a lot of hard coded sizes which make life harder when you want to make the website responsive. A quick fix would be to use "em", "rem", "vh" or "%" when defining sizes. In some place instead of using height or width to define the length of your container, use margin or padding to set the limits. You can also use "calc()". Use "px" sparingly.

    Marked as helpful
  • Lucas 👾•104,160
    @correlucas
    Posted almost 3 years ago

    👾Fala Bruno, tudo bem? Parabéns pelo desafio!

    Acabei de ver sua solução e queria te deixar duas dicas:

    1.Media query, nesse desafio aqui nem precisa usar media query, já que é só um card, bastaria você deixar o card responsivo substituindo as larguras de um valor fixo width para max-width desse jeito o card se ajusta de acordo com a tela.

    2.A imagem do NFT está perdendo as proporções fora do card, pra arruamar isso você precisa colocar display: block e max-width: 100% pra fazer com que a imagem fique dentro do container e ajuste de acordo com a tela.

    img {
        display: block;
        max-width: 100%;
    }
    

    Essa aqui é minha solução, se você quiser usar como referência: https://www.frontendmentor.io/solutions/nft-preview-card-vanilla-css-custom-design-and-hover-effects-b8D1k9PDmX

    👋 Espero ter ajudado e continue no foco!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub