Submitted about 4 years ago

CSS Flexbox, Vanilla JavaScript

@boedegoat

A solution to the Article preview component challenge

Solution retrospective

Hi, finally I done working on another fun challenge here. The result is quite great but not perfect for me. I'm not quite sure that the share popup part is already good enough or need some changes. So, any feedback would be really appreciated to help me grow. Thank you 😀

Code

Please log in to post a comment

Community feedback

Андрій Рогов•1,155
@Andrii-Rohov
Posted about 4 years ago
Great stuff, butt he share options are clickable even if they are not visible. You should place a visibility: hidden; to a pop up options menu
Timothy•285
@Timothy1982
Posted about 4 years ago
Hey, that's allrady looking good. Just a small side tip: If you give your social icon images a "display: block" they will align up nicer. ;) You can also include the SVG instead of linking them in the IMG tag.
Eric Salvi•1,350
@ericsalvi
Posted about 4 years ago
Hey,

This is a pretty solid solution. Not too much to pick apart here. Take a look at your accessibility issue reported on your solution, https://www.frontendmentor.io/solutions/css-flexbox-vanilla-javascript-D7ki7-LkQ/report Try to fix those when you can.

The social sharing button does something weird when checking on my iPhone in landscape view. Not sure if you have a way to test on that device or not.

The other thing I am seeing on my desktop is that the social sharing menu flashes briefly when the page loads than is hidden. Any chance you could rework it so that the social sharing menu is hidden from the start and not when the page loads?

Other than that, keep up the momentum!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord