CSS grid and DIY again :)

Community feedback

• 

  leverh•300

  @leverh

  Posted about 3 years ago

  Hey Yan, I think the whole thing looks great! As far as the grey goes, i used hsl(218, 22%, 67%) on mine. I use visual studio code which allows you to hover over the color you coded and then change it through the visualization of the color palette. Don't know if you can you it with scss though (that i noticed you're using).

  01

  Marked as helpful
• 

  Tesla_Ambassador•3,070

  @tesla-ambassador

  Posted about 3 years ago

  Hey Yann, pretty solid solution you've got here! For the text color problem, sometimes you can improvise (the challenges encourage us to be creative!) but your text color is really okay! The main thing I'd like to point out is the responsiveness, here's a tip:

  • I noticed that you set a "margin" property to your grid-container in order to center it. You might want to instead style your <main> like this:

  main {
      height: 100vh;
      display: flex;
      justify-content: center;
      align-items: center;
  }
  

  this will center your "grid-container" within your <main> at any screen width and it won't break your responsiveness! Happy Coding!

  01

  Marked as helpful