css grid, flex

Community feedback

• 

  Adriano•42,870

  @AdrianoEscarabote

  Posted 7 months ago

  Hi cga0108, hope you're doing well! I loved how your project turned out, but I’ve got a few suggestions that could be useful:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  The rest is fantastic.

  Hopefully, you'll find it helpful. 👍

  00
• 

  Vinayagam K•180

  @vinayagamRVK

  Posted 7 months ago

  The design looks good....it would have been much more better if it has some more amount of padding and margin....apart from it it looks great!!

  00