Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

CSS grid, Flexbox, responsive

@ikennarichard

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello, please what's the better way of setting up this project, useful tips to help me improve. Thanks a lot !

Community feedback

@faha1999

Posted

Hello, Ikenna Oguejiofor Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:

  • You might want to use semantic tags like the <main> to wrap your code, instead of div. like
<main class="container">
</main>
  • add alt="image-product-desktop" attribute in img

This would help improve accessibility.

  • add the below styles to the body. It will center everything
body {
    justify-content: center;
    align-items: center;
    display: flex;
    min-height: 100vh;
    flex-direction: column;
}
  • remove the below styles from .container & .wrapper
.container{
    /* width: 50vw; */
    /* display: flex; */
}

.wrapper{
/*left: 50%;*/
    background: white;
}

@media (max-width: 550px)
.wrapper {
    /*margin-top: 20px; */
    /* margin-left: 20px; */
   /*left: 50%;*/
 }
.product-details {
    width: fit-content;
}
}
  • Fixed the other HTML Validation error from the report.

  • Instead of using px, use relative units like rem or em to get better performance when the information on your page needs to be resized for multiple screens and devices. REM and EM apply to all sizes, not just font-size. You can code your entire page in px and then, at the very end, use the VsCode plugin px to rem to perform the automatic conversion px to rem

  • This is my solution of this challenge live, repo

I hope it will work. Happy coding.

Marked as helpful

0

@ikennarichard

Posted

Thank you Faha for the comments and awesome tips, ill get it done.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord