CSS Grid, React, components Responsive, react-routing

Community feedback

• 

  S MD suleman•3,510

  @sulemaan7070

  Posted over 2 years ago

  hey Azizbek Yunusaliev😄, you did a great job. here are a few tips to improve...

  1.when the items are added to the cart the users have no idea that items are added successfully... you can place a span positioned absolutely to the cart svg.. which indicates items added successfully to the cart.

  2.When I open the mobile-menu and start scrolling down the close svg is going to top .. you can stop that scrolling behavior by adding this JS code

  this stops the user from scrolling: 
  
  (document.body.style.overflow = "hidden")
  

    This will help in scrolling again(default) :
  
   (document.body.style.overflow = "auto");
  

  3.I also recommend to you increase the height and width of .cart-dropdown-container a little bit more...

  Everything else looks great !! happy coding💯👍🏻✅

  10

  Marked as helpful
• 

  P

  Jo89 😈•460

  @AhmadYousif89

  Posted over 2 years ago

  Hey Azizbek 👋

  Your solution looks Awesome 👍I just have a couple of notes that I hope it would be good for your project :

  • the animation is a bit too much may be readjusting the duration and the starting point would help (nit-picking I know 😅)

  • the animation on the header navigation tho is totally unnecessary (IMO) and doesn't make a lot of sense either 😐

  • the cart modal need to be a bit wider and taller to accommodate the items in it (I guess that you have added a fixed width and height on it 🤔)

  • the logic for adding the product to the cart doesn't make a lot of sense, instead of adding the same product twice or more you should just increase the quantity of that particular product, so if it doesn't exist initially in the cart you just push it to the cart with qty of 1, but if it's already in the cart you increase the qty by 1 or 2 or whatever the counter is at this point.

  • the lightbox animation looks good, but what I don't like is that the backdrop is being animated with it I think you placing them in the same component, try separating the lightbox/carousel from the backdrop and just animate the lightbox and maybe add a bit of delay so that the backdrop come first then the lightbox after like 200ms

  • I really loved the Authentication form section ❤

  I haven't really looked at the code so I can't give you my 2cents on it tho, but anyway I hope you find my notes helpful for you.

  Keep Coding 👊

  00

  Marked as helpful