Skip to content
Submitted 9 months ago

CSS old fashion

Abbas•30
@abbas-devlop
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

i would use flexbox to center the div instead of the old way where we use position absolute

Code

Please log in to post a comment

Log in

Community feedback

  • Prakhar Nagpal•60
    @slightlybelowzen
    • The <h2> element hasn't been sized correctly. The design spec uses 22px to style it, and since no size has been specified in the css, it defaults to the browser default of 1.5em which is 24px assuming a base font size of 16px (also since the base font size hasn't been set in the css for the body element.
    • It's a good idea to apply a reset of
    * {
  margin: 0;
  padding: 0;
  box-sizing: border-box;
}

    so you don't have default margins of elements messing with spacing and padding of elements.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord