css toggle ids

Community feedback

• 

  P

  Andrey•4,600

  @dar-ju

  Posted 8 months ago

  Hi Bisshy!

  I have no comments on how you implemented the JS part, it's quite concise and elegant, you're great. But there are a few points on the html code and other.

  • why are you using the hashtag #react if you haven't used react ?
  • bem is not used quite correctly, there is a tool where you can check bem errors - tree generator
  • use the <picture> tag if you have different images for different screen resolutions, if the image is the same, then it is better to skip this tag and just use <img>
  • if time or date is used somewhere on the page, then it is semantically necessary to use the time tag, in this case like this <time datetime="2020-06-28">28 Jun 2020</time> For us, as developers, this may not be important, but search engines are guided by tags
  • links to social networks should not be just images, firstly, because they cannot be clicked, which means you need to use the <a> tag, secondly, these are clearly background images, so they need to be connected via css - background-image
  • you need to check the state of the follow button, it does not change its background and color, as in the images in the task

  Otherwise - great job, good luck with your future developments!

  00