Skip to content
Submitted over 2 years ago

css

Faisal Omar•50
@faom002
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)
Code

Please log in to post a comment

Log in

Community feedback

  • Panji•2,090
    @pperdana

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have some additional recommendations for your code that I think you'll find interesting and valuable.

    📌 Add <main> tag as semantic HTML in code

    • The <main> tag is a semantic HTML element that is used to define the main content of a web page.

    • The <main> tag should be used to wrap the primary content of a web page, such as the main article, section, or body of text.

    for example code:

    <main>
  <div class='container'>
    <h1>Article Title</h1>
    <p>Article content goes here...</p>
    .......................
  </div>
</main>

    In the example above, the <main> tag is used to wrap the <div> tag, which contains the primary content of the web page. This tells both human readers and search engines that the content inside the <main> tag is the most important and relevant content on the page.

    I hope you found this helpful!

    Happy coding🤖

    Marked as helpful
  • Ecem Gokdogan•9,380
    @ecemgo

    Some recommendations regarding your code that could be of interest to you.

    HTML

    • If you want to use the recommended font-family for this project, you can add the following between the <head> tags in HTML file:
    <link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Outfit:wght@400;700&display=swap" rel="stylesheet">

    CSS

    • After adding them to the HTML, you can add this font-family to the body in CSS file:
    • In order to center the card correctly, you'd better add flexbox and min-height: 100vh to the body
    body{
   font-family: 'Outfit', sans-serif;  // google fonts which is suggested
   background-color:hsl(212, 45%, 89%);
   /* padding: 100px; */
   display: flex;
   flex-direction: column;
   justify-content: center;
   align-items: center;
   min-height: 100vh;
}
    • If you use flexbox in the body, you don't need to use margin in the .panel to center the card
    • If you use max-width instead of width and height, the card will be responsive.
    .panel{
   /* width: 340px; */
   max-width: 340px;
   /* height: 520px; */
   /* margin: auto; */
}
    • If you want to make the card responsive and the image will be positioned completely on the card, you'd better add width: 100% and display: block for the img in this way:
    .qr-image{
   /* width: 330px; */
   /* height: 330px; */
   width: 100%;
  display: block;
}

    Hope I am helpful. :)

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord