Skip to content
Submitted almost 3 years ago

Cypto Tab

sass/scss, accessibility
Tertsegha Kpughur-Tule Moses•210
@Mosestule2003
A solution to the NFT preview card component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Please I would love any feedback

Code

Please log in to post a comment

Log in

Community feedback

  • Okafor Raphael•240
    @OkaforRaph

    Hey Moses, congratulations on completing the challenge! You did a great job 😉

    Let me give you some little tips for optimizing your code:

    • First, for semantic HTML, the section tag is expected to wrap the div and not the other way round.

    • Always make use of relative unit of measurement like "rem" instead of "px".

    Hope this help! Happy coding 😁

  • Rohit Kumar Saini•270
    @rockingrohit9639

    Hey, @Mosestule2003 Congratulations on your submission.

    I looked at your design and found that it could be improved more. The things which you can improve are --

    • Use the font-size of paragraph to be 18px and don't have any <br> in your <p>. It will automatically fit with the container width.
    • The color of the paragraph also does not match, you can change it too.
    • You should have all the content in <main> and you should also have <footer>. So your report will not be having any issues.
    • Add <!DOCTYPE html> at the top of your HTML document.
    • You should have width: 100% in the CSS not at the direct element.
    • You should not have <p> inside H3 or any other heading element, instead you can use <span>.

    I hope this feedback will help you a little bit in improving your design. All the best.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord