Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Dancing card

@ClaudioAmareno

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi! I'll be glad for your review and tips how to improve my code in html and sass :)

Community feedback

@rostyslav-nazarenko

Posted

Hi! Amazing solution! 😍

I will try to provide feedback, but it is mostly tiny bits here and there.

  • It is not recommended to set `html { font-size: 62.5%; } read more about it here. I'd recommend reading this entire article.
  • Change height: 100vh to min-height: 100vh. If users set a slightly bigger font size they wouldn't be able to scroll and see the whole component.
  • Look at reports. In a real project, you wouldn't use h1 for this but here it is a stand-alone project. Remove p element from button.
  • Use em for media queries too.

Have a nice day!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord