Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Desafio do QRCODE

#cube-css

@WpMateus

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Primeiro Desafio Front-End Mentor / QRCode

Community feedback

@elioflo

Posted

Hi there! Your solution looks good.

I noticed that you used margin to center the .conteudo class div, but if the viewport height is too short, the .conteudo div may not look centered anymore. The Both Horizontally & Vertically css-tricks section on css-tricks has some advice and alternatives for centering elements.

In your case, you could try using the following code to center the .conteudo div:

.container {
    display: grid;
    min-height: 100vh;
    place-items: center;
}

This method will ensure that the .conteudo div is centered for any viewport height size.

You're doing a great job with your coding. I hope this comment helps you improve your solution!

Elio Flores

0
Finney 3,030

@Finney06

Posted

Hello there 👋. Good job on completing the challenge !

Here are some suggestions regarding your code that may be of interest to you.

HTML 🏷️:

To clear the Accessibility report:

  • Wrap the page's whole main content in the <main> tag.

  • Use HTML5 semantic elements such as <header>, <nav>, <main>, <aside>, and <footer> to define these sections.

Here is a web accessibility evaluation tool📕 to check your webpage for any remaining errors or warnings related to landmarks.

I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord