Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Desktop QR Code Solution using HTML and CSS

Diksha Bhat•10
@Diksha192001
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


  • I am not sure if i did the prefered/correct way for keeping a square inside a rectangle. Can anyone please check?

  • And also in general tell me if there are any major beginner mistakes that i have done, which could have been avoided or done in a better way.

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Mobile_Koda•140
    @Lemon-stack
    Posted over 1 year ago

    You did good👍 Here's what I think : • You didn't had to necessarily upload all the work files, they were for guidance. Only your HTML, CSS and image files would do. • Giving a class and setting it's background-image wasn't really necessary, you could have just included your image tag and adjust the width and height settings. Apart from that.... your solution was 🎯 I hope you found this helpful 😊.... Happy Coding 🌟

    Marked as helpful
  • Andi Gashi•660
    @Andigashi1
    Posted over 1 year ago

    Hey i'll do my best to help with the experience i have. Firstly i suggest that you separate the css from the html by writing it in a separate file. Second, instead of creating the .square div, it would be easier to put the img directly in the html not in the css and giv it the margin there. And lastly in order to use the correct colors, the zip files provides you with a styles-guide.md which contains all the colors, font sizes and families.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub