Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Desktop-first product preview card component

Dhanya•50
@dhan5a
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I am not sure how images from my code can be seen on Github. The image is currently missing in the website. Would appreciate to know more about this!

There is a small gap below the main picture,which makes the text component a little longer than the picture. I'm not sure how to make both components to be of the same size.

For the mobile view, the image has been resized, but it looks awkwardly stretched,and there is (again) a small gap between the picture and the text component.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Amparo•80
    @amparoamparo
    Posted over 2 years ago

    Hey Dhanya! Great start!

    The problem with the image is that its path is set to "images/image-product-desktop.jpg", but you have no "images" folder in your repo. Same with the cart icon image.

    I think part of the issue with the image size is that it has a fixed height of 500px.

    Have you tried using grid instead of flex for the card itself? As well as playing around with different widths for it, rather than a percentage.

    Hope that helps! :)

    Marked as helpful
  • DHEERAJ PUJYAM•200
    @dheeraj-90040
    Posted over 2 years ago

    I think your image is a source from the desktop. load the image in the folder where u kept the index.html file and give the source directly. then it will take the image and update it in the git repo too.

    thank you.

    Marked as helpful
  • DHEERAJ PUJYAM•200
    @dheeraj-90040
    Posted over 2 years ago

    Hi, Nice meeting you. I saw the problem. I think you used CSS - flexbox and set it to the column direction. what u do is correct. my solution is batter decrease the width of the image and increases the height of the image. and the card width should also increase. that is the problem. and removing wrapping components. try this ma work. or try using bootstrap container

    Thank You

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub