DevJobs App | Vite | React | SASS | TypeScript | React-Virtuoso

Community feedback

• 

  Damjan•200

  @iDamjan

  Posted almost 2 years ago

  Hi,

  okay wow, awesome, i am really curious of your coding experience, and how long have you been doing it. You also added test, which is really awesome.

  I would add really minor things, my opinions:

  • Don't rely on Viewport in the JSX, i think that should be always handled by CSS/SCSS and media queries (in case there is some specific reason i am missing)
  • I think you should put all the views/pages in a Views folder or Pages folder and any other view as well, i can see that you added this in Router folder but that may be really confusing :D . As this is a becoming a medium project, with more than 10 components its really hard to navigate.
  • I think that you really tried to separate things and make it simpler and you ended up with too many components, and its really hard to navigate and review this. Ideally this should be constructed with up to 5 components i think.
  • If there is nothing to load more, then disable the button or hide it.
  • Its weird that you can only scroll inside of the jobs, it comes intuitive to scroll in the outside as well
  • Interesting update would be to make the search to be live and happening immediatly, its nice improvement.

  I hope my comments will help and not only make you angry (I know how comments on PR can make a person angry), but remember this are just my thoughts, your code is awesome and really good job :))

  Regards, Damjan

  11

  Marked as helpful