Skip to content
Submitted over 1 year ago

Devjobs web app solution | by MV

react, react-router, sass/scss, vite, typescript
P
Marcos Valenzuela•710
@Dantalian5
A solution to the Devjobs web app challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

This is my first React-Typescript project, and it was quite an interesting journey filled with lots of new learning opportunities. It took some time to get everything in place.

Weak Points:

  • The use of react-router in this specific case was a bit confusing when navigating through the page, which made me doubt whether it was the right solution or not.
  • Using TypeScript made many things easier and eliminated a lot of potential errors along the way, but I realize that the indiscriminate use of 'any' wasn't the best choice in some cases, and in others, the type declarations could perhaps be improved.
  • After analyzing more advanced projects from others, I could see that maybe a more appropriate organization of the project structure and components in general could have been applied.

Despite everything, it was a lot of fun, as always. I look forward to your advice and feedback, and thank you in advance ;) .

Code

Please log in to post a comment

Log in

Community feedback

  • BrunoMoleta•700
    @brunomoleta

    Buona sera Marcos,

    I've reviewed this project of yours also with a PR and everything. First, do not feel obliged to accept the pull request.
    Unfortunately, I ended up breaking the filter feature :(.

    I wanted to clean up the action prop that was hard to understand.

    And I know it's unnecessary to have that, though I couldn't go around it. But please check out the Git commits, as I made an effort to make each as specific as possible.

    The main thing I did was to organize the states using Zustand state manager. Also, your Button component had a reserved word "type" at your prop. I changed the name to isLink with the boolean type since it is a link or not.

    Please also check the initial color setter function. I believe it got cleaner.

    The feat you did at filtering the form as the user types is swell. Congratulations on developing it.

    Best regards from Brasile, Bruno

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord