DHBLee_FAQ using HTML, CSS, and JS

Solution retrospective
Practice
What challenges did you encounter, and how did you overcome them?Practice
What specific areas of your project would you like help with?Have a good one!
Please log in to post a comment
Log in with GitHubCommunity feedback
- @MarziaJalili
Hi there!
The project works as expected. It looks great.
Some sort of suggestion:
- Frist, there is no need to set a separate element in html for the background image (
<div class="background">
).
Instead use the
background-image
property to get it done, take the code below as an example:body { background-image: url("path of the image"); background-repeat: no-repeat; /* we only need one of it */ background-position: top; background-size: 100%; /* to take the entire horizontal space*/ }
- Second, instead of using an image for the toggle buttons, use the
<button>
element an then wrapp the image inside. This gives more information to the screen readers and specifies it's a button rather than an actual image.
The
<button>
element comes with some default styles. So, get rid of them using the code below:button { border: none; background-color: transparant; }
Hope you find the a good one😎
- Frist, there is no need to set a separate element in html for the background image (
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord