Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 4 years ago

Dine Restaurant with HTML, CSS, JS

Mareike•130
@MareikeW
A solution to the Dine restaurant website challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


How could I improve the From for Reservations and the Event-List with the three headings?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Raymart Pamplona•16,040
    @pikapikamart
    Posted about 4 years ago

    Hey great work but there are issues that I saw. First, your css declarations, we can't preview the desktop state since I saw in your css in your repository, you declared in the @media (min-width: 1440px) the styling that is supposed for desktop resolution right. But the thing is that, since you made it mobile first as far as I can tell, setting the desktop styling for min-width: 1440px, will only allow user who have their desktop width of 1440px wider and any lower than that, will only see the mobile version state and you don't want that. Maybe adjusting your min-width like 1024px something like that would be awesome. Your declaration of javascript. I see that you only created one js script and the issue with is your other html, you made it dependent on it, both your .html script is written on only one, that is why an error is prompting saying that there are variables who are null, since the variables element, is in another .html file. It would be better that you create a seperate js files right for both you .html files so that error wont be prompted. For for form reservations, it is pretty I think, do you mean the js for it or the stylings and that event-list? Could you be more specific about it? Well that are just some recommendations^^

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub