Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Display flex, and media query

Karim 10

@KarimSalah26

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


-It's a simple project. -I'm sure it works. But I think responsive parts could be better.

  • If there is a best practice available, Sure I'd like to check it.

Community feedback

IRVINE MESA 1,855

@DrMESAZIM

Posted

hi.

I do have one extra suggestion to make your solution look great by matching the expectations of the challenge

lets set the background ccolor of the body to to the CSS code background-color: hsl(212, 45%, 89%);

If this difficult fior you let let me know and I can do a video tutorial for you

Marked as helpful

1

@0xabdulkhalid

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • This solution lacks semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers
  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.
  • So fix it by replacing the <div class="container"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page.

CSS 🎨:

  • Looks like the component has been centered correctly. But without the height value the component itself i hanging at top, So let me share a css snippet which may help you
  • Just add the following style rule
body {
    min-height: 100vh;
}
  • Now your component has been properly centered

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord