Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 11 months ago

E-Commerce add to pane page using JavaScript

KHLIFI BRAHIM•210
@khlifibrahim
A solution to the E-commerce product page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Manish Kumar•90
    @manishkmr49
    Posted 11 months ago

    Feedback for the Solution

    Semantic HTML

    • Strengths: The use of semantic HTML elements like <header>, <nav>, and <footer> is commendable, making the structure clear and meaningful.
    • Suggestions: Consider using more semantic tags for specific content sections like <article> or <section> to further enhance the document structure.

    Accessibility

    • Strengths: The site is partially accessible, with some ARIA attributes and keyboard navigability.
    • Suggestions: Ensure all interactive elements have appropriate aria-labels and roles. Add alt text to images for screen readers, and verify that color contrasts meet WCAG standards for better accessibility.

    Responsive Design

    • Strengths: The layout is responsive and adapts well to different screen sizes, maintaining a good user experience across devices.
    • Suggestions: Test on a variety of devices and orientations to identify and fix any minor responsiveness issues. Ensure the navigation menu is easily accessible on mobile devices.

    Code Structure and Readability

    • Strengths: The code is well-structured and organized, which makes it easy to read and maintain.
    • Suggestions: Use consistent indentation and descriptive class names. Break down large CSS files into smaller, modular files for better maintainability. Refactor repetitive code into reusable components to reduce redundancy.

    Design Consistency

    • Strengths: The implementation closely follows the provided design, ensuring a visually appealing product page.
    • Suggestions: Pay close attention to details such as spacing, font sizes, and alignment to ensure they match the design exactly. Consistent margins and padding can make the overall design look more polished.

    Overall, the project demonstrates strong frontend development skills. With a few enhancements in accessibility, code organization, and design precision, it could be even better. Excellent work, and keep refining your skills!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub