Easybank landing page

Hi Shibu7, I have reviewed your code. All code seems pretty well and the design is looking nice. There are some suggestions I would like to give regarding HTML markup.

1- No use of header tag: There should be a header tag that will contain the heading section i.e. navigation of the page.

2- No use of the main tag: There should be the main tag after the header element and all of the section elements should be encapsulated into it.

3- Semantically and for SEO purposes only one h1 element is considered as best practice. You can use h2 and h3 elements for the lower-level headings.

I hope these suggestions are helpful. Thank you!

Hi Shibu,

Generally I find your code very clean and well written so hats off.

I have a couple of questions. In your style.css file you commented out the basic reset on line 35-40 containing the "box-sizing: border-box;". Any particular reason for that?

You have a conditional if-else statement in your app.js. Have you ever considered using conditional ternary operator? Perhaps something like: let toogleImg.src = (isOpen) ? './img/icon-close.svg' : './img/icon-hamburger.svg'

Anyways keep up the good work!

Cheers