@darkshadowultimate
Posted
Hi Anna, I really love your landing page 😍.
I’d have two suggestions if you don’t mind:
- I’ve seen that you focus even on accessibility, so I think that it would be better if the buttons “Request Invite” could have a different hover effect, because as it is right now, the contrast between button’s background and button’s text is not maintained and the text is difficult to read (for someone who has difficulties to read)
- I’ve noticed that there’s a slight tremble on the hover effect of the cards under the section “Latest Articles”. I dunno what it is, but I wanted to point that out in case if you hadn’t noticed 😉.
Anyway, really good job. I hope that with some more practice I’ll reach your level.
@brasspetals
Posted
@darkshadowultimate Thanks for taking the time to look at my solution and give feedback! I really appreciate it. 😄
- Good catch on the weird shifting. 👍 It only happens in Chromium browsers, but I think I've fixed it now by adding
backface-visibility: hidden
to the article cards. - I agree with you on the hover states, but was just following the design of the challenge's active states. I'm sure for proper accessibility the contrast there would need to be changed, as well as some of the hover states (the bright green hover on the article title links isn't easy on the eyes, for example). I know "just following the design" isn't a good excuse though, and I will definitely dig more into color accessiblity - thank you!
@darkshadowultimate
Posted
@brasspetals You're welcome! 👍🏻