Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 4 years ago

EasyBank Landing using HTML, CSS and JS

Suraj Kandlakunta•410
@Suraj1333
A solution to the Digital bank landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This has been a fun project to do. This is my only second project using JavaScript. I have used JS for the mobile navigation toggle. Any feedback from the community would be helpful! Happy Coding!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • tediko•6,700
    @tediko
    Posted about 4 years ago

    Hello, Suraj! 👋

    Well done on this challenge! Your solution responds well. Here's my suggestions:

    • Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.
    • Set a max-width on the header, .hero__content etc. containers and center it horizontally so the content of the page doesn't look too stretched on large screens.
    • Use headings for your .head and .head-one.
    • Change your logo image alternative text to be more descriptive. Something like "Easybank - home page" would be good.

    Good luck with that, have fun coding! 💪

  • Account deletedPosted about 4 years ago

    Hey @Suraj1333,

    Great job on this challenge! The design is looking well in comparison with the original design.

    I wanted to bring your attention to the navbar animation. It has bug whenever you resize from desktop view to mobile view. What happens is that the navbar animation plays out and the reason for that is because you have animation properties specified inside a media query @media (max-width:700px){...}

    To fix this, simply place the animation properties outside of the media query

    .nav__links{
        transform: translateX(100%); 
        transition: transform 0.5s ease-in;  
    }
    

    Other than that. I think you did an amazing job with this challenge.

    Happy coding!

    //Kenny

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub