EasyBank responsive website using bootstrap5 and scss

Community feedback

• 

  Mo•840

  @MohamedAridah

  Posted about 3 years ago

  Hello @AbdulkerimAwad, Yo did good job for this challenge🎉👍. Your website is Responsive and that's really cool.

  However i have some notes for you:

  • Don't use compiled css files for learning purpose projects. it will be impossible to read your code form style.css file.

  • css nesting rules are so long. and this will make browser take time to render it. example for what i mean:

      html body .main-container header .next-generation button
  

  it could be shortened to

      .main-container header .next-generation button
  

  • try use transition property specially for .next-generation button and footer links.

  • change .card-title color property of the articles on hover

  I hope this wasn't too long for you, hoping also it was useful😍.

  Goodbye and have a nice day.

  Keep coding🚀

  12

  Marked as helpful
• 

  Ricardo Magalhães•180

  @AmodeusR

  Posted about 3 years ago

  It seems you got bipolar with the mobile menu, it opens from top to bottom and suddenly it becomes a box xD And a tip I could give you is to give a smaller max-width to the "reasons you should choose Easybank" section, the text of the items there get too wide at about 400px screen width.

  Besides that? Oof, I can't imagine how hard it were to make this challenge, I already got fearsome just by imagining the media queries (⊙_⊙;) Great job 👌

  11

  Marked as helpful