Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

E-Commerce Product Page created using React and Sass/SCSS

react, sass/scss, redux
Lorand Kalmar•170
@Lorand98
A solution to the E-commerce product page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello :) Could you please give me some feedback regarding my project? I feel that the code is not optimized and there are tons of places where I can improve my code. For example, in the components > Article > ArticlePhotos components, I'm changing the photo using the selectPhotoHandler function and I feel like it's very slow when doing the first few switches/selections (it's reacting slowly). Could you please confirm what could be the reason for this? Is there any more optimal way to switch more fluently between the photos?

Also, could someone please check my sass file structure? I'm keeping everything general (mixins, variables, colors, etc...) under the sass folder and I'm keeping the component-specific styles in CSS modules, in the same folder as the components, for example, Article.jsx -> Article.module.scss. Is my sass development mode alright? Also, should I better keep my color-related variables in the colors.scss file? Or is this ok the way I did?

Your feedbacks are very welcome! :)

Thank you and best regards, Lori

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

No feedback yet. Be the first to give feedback on Lorand Kalmar's solution.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.