Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

E-commerce product page

#sass/scss

@AmritPal91

Desktop design screenshot for the E-commerce product page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


Can someone tell about best practices for this challenge?

Community feedback

@juanprog97

Posted

hey Amritpal Singh, I see that you are missing the border that indicates the selected image, here is a solution so that you can lower the opacity and still have the border visible.

1- you should wrap the img in a div . For the div the border style is applied and in the child img the opacity is lowered and thus does not affect the visibility of the border. HTML

<div class="container-img">
   <img src="https://http2.mlstatic.com/D_NQ_NP_658639-CBT50339432941_062022-W.jpg">
  </div>

CSS

div.container-img{
  display: block;
  width:300px;
  height: 300px;
  border: 6px solid black;
  
}
.container-img img{
  width: 100%;
  height: 100%;
  opacity: 0.4;
}

happy coding👍🏻🔥💯

0
S MD suleman 3,530

@sulemaan7070

Posted

hey Amritpal Singh😄, congratulations on completing the challenge here are a few tips to make your site better...

1.You can the cursor:pointer on the +,- and the delete svg..

2.When I am adding 4 items.. and pressing the Add to cart the 4 should become 0.

3.on the mobile: the images inside the carousel are getting squeezed you can use the object-fit:contain to tackle that problem..

4.And for the (mobile-menu) or .navigation you can add

.navigation {
    position: fixed;
}

so that user cannot scroll down the menu..

Everything else looks great!! happy coding👍🏻🔥💯

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord