Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Ecommerce sneakers website using react

react
Salma•80
@salmaaboudou
A solution to the E-commerce product page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Any feedback and suggestions on how I can improve are very welcome! 💗

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Zeyad Mohamed•320
    @ZeyadMohamed1805
    Posted over 2 years ago

    Awesome work! I do have some small suggestions that might help:

    1. When the main image is clicked on, it directs to a dead page. This might be due to a file that has not been uploaded properly.
    2. The cart is overlapping the navigation bar. Positioning it a little bit down would make it better.
    3. When an item is added to the cart, the counter in the bottom is automatically set to 0. Moreover, when another quantity is choses, it adds to the existing quanity. The problem with this is that the user will not be able to decrease the quantity in the cart. He / She will be forced to delete the items, then repeat the process. The fix for this is to set the items in the cart to the number in the counter instead of adding them.
    4. On the mobile version, the size of the image is slightly huge. A quick fix for that is to set its max-width to like 500px and the centering the image.

    These are just minor adjustments. Other than that, your website is great & your hard work is clearly displayed. I hope this feedback helps. Please check out my solutions & react / comment to them. It really helps!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub