Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 7 months ago

Ecommerce Product Page Main w/TailwindCSS

P
Mukarram Haq•440
@MukarramHaq
A solution to the E-commerce product page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm really proud of two things:

  1. The slider
  2. The lightbox design

I think writing cleaner code would be very beneficial in the future.

What challenges did you encounter, and how did you overcome them?

I think the main challenge I encountered was the positioning of the cart. For some reason, it would only go as far as the middle of the page.

So to tackled that I learned a little about position and I was able to solve it after that.

Another challenge that I faced was that whenever I would click an image in the lightbox the lightbox would close. In order to tackle that I put the following code if(e.target !== e.currentTarget) return in the addEventListener for the lightbox.

What specific areas of your project would you like help with?

I would really like some help with how I chose the elements in JavaScript. Do you guys think that was the only way to do it or is there a better and cleaner way to go about it? Maybe create a new .js file and get them as objects?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • jonathanudeh•340
    @jonathanudeh
    Posted 7 months ago

    Based on how your coded is structured I think using if(e.target !== e.currentTarget) return for the solution was a good choice. overall you did a very good job.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub