Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

E-comerce

bootstrap, react, next
Ambadi M P•380
@Soaphub
A solution to the E-commerce product page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Did some changes to the initial design. Please let me know the responsive design.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Zeyad Mohamed•320
    @ZeyadMohamed1805
    Posted over 2 years ago

    Great work right there! I do have some observations I'd like to share with you:

    1. While hovering on the thumbnail images, I noticed that it was shaking. The reason its doing that is because normally it doesn't have a border, so when you hover the border is added, which increases the size of the image. A quick fix for that is to actually add the border to the image before hovering, and make its color transparent. Then when you hover, just change the border's color to orange and it will hopefully not shake.
    2. I noticed that the images overlapp with the header in the mobile app. I don't have a fix for that but I just wanted to point it out in case you didn't notice.

    Other than that, I think you did a great job on this project! Keep it up and I hope this feedback will be beneficial!

    Marked as helpful
  • j0sephh123•140
    @j0sephh123
    Posted over 2 years ago
    • There is duplicated code in pages/. You can look into _app.js how to have a single layout

    • To load a global css - you can use this article

    • Avoid accessing the DOM directly. For example in Cart.js you can set directly in the JSX <p id="title-cart">{'set the stuff here'}</p>, which you are currently doing inside useEffect

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub