Skip to content
Submitted over 2 years ago

Event-Listener, BEM,SASS

Franco Minati•60
@FrancoMinati
A solution to the Interactive rating component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Im not really sure if i did it in the best way possible, so im looking for tips and advices.

Code

Please log in to post a comment

Log in

Community feedback

  • szam•800
    @k-stopczynska

    Hi,

    your solution looks really good, congratulations:)

    Few things I might suggest: Use array methods instead of loops, it's more readable, faster and convenient (e.g. looping through buttons, you could use forEach method which is available for HTML collections and Node lists).

    For Sass: it's a little overkill using Sass for project so small, but when you are using it: look at your modules structure. Here you can find tips how to structure it: https://itnext.io/structuring-your-sass-projects-c8d41fa55ed4. Kevin Powell has also youtube video on this topic.

    And one another thing: with new version of Dart Sass it's not really recommended to use @import. Kevin also has a video on using @use and @forward, it's also available in Sass documentation.

    Hope this helps:)

    Happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord