Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Expanses Chart Component

Nino Khurtsidzeβ€’ 400

@Ninunutsi

Desktop design screenshot for the Expenses chart component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedbacks are welcome!

Community feedback

visualdennisβ€’ 8,255

@visualdenniss

Posted

Your solution looks great and responds very well to different browser sizes!

While everything seems to function and work without any issue, one improvement area could be perhaps having the days and their heights not hard coded, instead you can try to have the data passed dynamically. This way your app could scale better in general if later on new and more data were to be added.

instead of day[0].style.height = "50px" day[1].style.height = "90px" day[2].style.height = "130px" ...

you can have an array of objects like [ {id: 0, height: 50, day: mon}, {id: 1, height: 70, day: tue}...]and map through that data using map() method etc.

Hope this helps! Good luck on upcoming challenges :)

Marked as helpful

0

Nino Khurtsidzeβ€’ 400

@Ninunutsi

Posted

@visualdenniss Thank you!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord