Expenses chart component

Community feedback

• 

  Elaine•11,360

  @elaineleung

  Posted almost 3 years ago

  Hi Paweł, well done on this challenge! I think you did an excellent job with your forEach methods, and even if it took a while to figure it all out, I'm sure these are skills that will take you far.

  I see you using a switch statement for applying the style to the current day bar; most of the code in the cases are actually fairly similar, so you can consider how to make it "DRY-er". Here's what I did instead in my code to condense all that into a ternary operation:

  const currentDay = new Date().getDay()
  
  data.forEach( (info, idx) => {
     ...
     idx !== 6   // this means if the data is not for Sunday, whose idx is 6
        ? idx + 1 === currentDay && barDiv.classList.add('highlight')
        : currentDay === 0 && barDiv.classList.add('highlight')
  }
  

  One final suggestion I have is to add a try... catch for your fetch method in async/await just to catch errors in case there are any.

  Keep leveling up on that JavaScript! 😊

  02

  Marked as helpful
• 

  Patrick Senchim•50

  @blayzking

  Posted almost 3 years ago

  Hi, I keep getting this error, 'Access to fetch has been blocked by CORS Policy.' Did you encounter this? And how did you work your way around it?

  02