Skip to content
Submitted over 2 years ago

Expenses chart component

Tommy Miguel•300
@CodingTimmyeth
A solution to the Expenses chart component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What can I do to improve my JavaScript code?

Is my HTML/CSS code understandable I found that I have written quite a lot of code, let me know so I can improve in future projects.

I found working from mobile to desktop really easy!

Code

Please log in to post a comment

Log in

Community feedback

  • P
    UreaLaden•280
    @UreaLaden

    Overall I think your solutions pretty good for a start and it is fairly easy to understand. The biggest issue is that this solution is not reusable. You're hardcoding a lot of strings and values so this can't be used in any other context. There's quite a bit of repeat code which should tell you that you may need to include some functions or do some refactoring. Your repo contains the data.json but you copied your own. Why not just read from the json file and use that instead? I love your use of css variables. One last note and this is something i'm constantly struggling with. All of your positioning and sizing may be pixel perfect but you'll want to start considering different viewport sizes. While it may look decent on your screen, it'll probably look strange on another. Great job!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord