Expenses Chart Component using HTML, SCSS, JS (RWD)

Community feedback

• 

  Elaine•11,360

  @elaineleung

  Posted about 3 years ago

  Hi Paulina, well done on this challenge and writing out all that JS!

  This is more of a UX comment: At first I thought the amount tags weren't working, but then I looked at your code and realized you wrote them as click events. I think that unless there had been some explicit instruction (such as, "click to see amount"), I really would not have known the bar is meant to be clicked on for the amount to show up (plus I also worked on this challenge and know the brief). Also, since there is already some change seen when a user interacts with the bar, as in, hovering over the bar changes its color, there might not be a thought that there's more interaction. In terms of UI, I think you can try adding a bit more padding around the amount tags.

  Once again, great work and looking forward to more 🙂

  11
• 

  Gabriel Ruiz Varela•50

  @GabrielRuizVarela

  Posted about 3 years ago

  Hey, nice work! A couple of things I would add is parsing the json file directly and getting the maximum from that and not manual. Here an article that can be useful: https://developer.mozilla.org/es/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse

  P.S.: I like your the clarity of your code.

  Cheers!

  11