Expenses chart component using React.js and Sass

Community feedback

• 

  Laharl•1,000

  @UrbanskiDev

  Posted almost 3 years ago

  Hello MartinLednar !

  Congratulation on finishing this project

  I have a suggestion to make it better !

  1. Some elements of your mobile responsive is broken a little broken when you make the screen too small. I recommend you to use the property min-width to avoid it.

  Here's an example :

   .overview-container {
    background-color: var(--pale-orange);
    border-radius: 15px;
    color: var(--dark-brown);
    height: -webkit-max-content;
    height: max-content;
    margin-top: 25px;
    padding: 28px 30px;
    width: 100%;
    min-width: 300px;
  }
  }
  

  I really like the fact that you can hover on the column of the day to get precise data of the day. I also liked that you used CSS variable, it is a good design to follow to make your code easy to modify !

  You left a media query unused in your App.css file, you can remove it if you don't need it !

  Otherwise,you did a good job on this project, keep going and I hope it is helpful !

  01

  Marked as helpful